-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31203: Fixed wrong connection being used for database creation when SiteAccess option is used #2908
Conversation
…ss option is used
eZ/Bundle/PlatformInstallerBundle/src/Command/InstallPlatformCommand.php
Outdated
Show resolved
Hide resolved
Instead of the constants and the private method here. Wouldn't it be more readable and simplify the code if we simply expose a It's not like this is the only place that we will have to deal with this afaik :) WDYT @adamwojs ? |
eZ/Bundle/PlatformInstallerBundle/src/Command/InstallPlatformCommand.php
Outdated
Show resolved
Hide resolved
@andrerom I agree. |
@mateuszbieniek Travis is failing with:
Probably related to this PR, could you have a look? |
Yup - for some reason, with default configuration connection name that is returned is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! Tested with default repository and custom configurations.
Also verified using patches on kernel 7.5.6 (first applying patch from #2900 for 7.5)
Could you merge it up? |
@lserwatka done a366ffd |
This PR is a followup for #2900 which adds an additional connection parameter for
doctrine:database-create
so correct database is created whenezplatform:install
command is executed using SiteAccess with connection different than default.